----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45443/#review126129 -----------------------------------------------------------
Ship it! LGTM - Jeff Holoman On March 30, 2016, 10:37 a.m., Tristan Stevens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45443/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 10:37 a.m.) > > > Review request for Flume, Grant Henke, Grigoriy Rozhkov, Jarek Cecho, Jeff > Holoman, and Ashish Singh. > > > Repository: flume-git > > > Description > ------- > > Change to Flume Kafka Source and Sink to allow Flume event headers to be > passed from Sink to Source (as can be done currently with Kafka Channel) > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst 5149ab5 > > flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java > 2e2140e > > flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSinkConstants.java > c84dec0 > > flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/TestConstants.java > f99be53 > > flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/TestKafkaSink.java > 1852099 > > flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java > db806cc > > flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSourceConstants.java > 2999cf2 > > flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceEmbeddedKafka.java > 46d545f > > flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSource.java > 8e04da8 > > Diff: https://reviews.apache.org/r/45443/diff/ > > > Testing > ------- > > Passes existing unit tests and added specific tests on Sink and Source for > avro headers. Also tested end-to-end on test cluster. > > > Thanks, > > Tristan Stevens > >
