----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48161/ -----------------------------------------------------------
(Updated June 13, 2016, 2:14 p.m.) Review request for Flume. Changes ------- address first branch requests Bugs: FLUME-2918 https://issues.apache.org/jira/browse/FLUME-2918 Repository: flume-git Description ------- The way TailDir source checks which files should be tracked was improved. Existing implementation caused unneccessary high CPU usage for huge (+50K files) directories. This fix allows users to eliminate continous listing of parent directory (on each Source.process invocation) and introduce a more performant method for listing&matching files. used java.nio.file.DirectoryStream to filter files made pattern match calculation optionally cached added junit tests added javadoc added license Diffs (updated) ----- flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 5b6d465 flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java PRE-CREATION flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java 8816327 flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 6165276 flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java PRE-CREATION flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java f9e614c Diff: https://reviews.apache.org/r/48161/diff/ Testing ------- mvn clean install -DskipTests -> built junit tests for flume-taildir-source module -> passed Thanks, Attila Simon