Ah, I didn't notice this thread. Great. Mike
On Mon, Jun 13, 2016 at 12:25 PM, Lior Zeno <[email protected]> wrote: > We can use the same style Kafka is using: > https://github.com/apache/kafka/blob/trunk/checkstyle/checkstyle.xml > > On Mon, Jun 13, 2016 at 10:14 PM, Hari Shreedharan < > [email protected]> > wrote: > > > I agree. Checkstyle is pretty useful - we should add it. > > > > On Sat, Jun 11, 2016 at 7:50 AM Lior Zeno <[email protected]> wrote: > > > > > Hi guys, we should make the reviewing process easier and more focused > on > > > correctness rather than style issues. I suggest enforcing our code > style > > ( > > > https://cwiki.apache.org/confluence/display/FLUME/Code+Formatting) at > > > compile time using the maven checkstyle plugin ( > > > https://maven.apache.org/plugins/maven-checkstyle-plugin/). This will > > make > > > the reviewing process easier, and will make sure that all committed > code > > is > > > strictly following our code style. > > > What do you think? > > > Thanks > > > > > >
