[
https://issues.apache.org/jira/browse/FLUME-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393413#comment-15393413
]
Mike Percy commented on FLUME-2959:
-----------------------------------
Thanks for the patch, Lior. Some review feedback:
1. I don't think the -ng stuff is really helpful and I don't think we need to
change it. We do already have flume-tools that is missing the -ng suffix so
it's not unprecedented.
2. The POM should not have flume-parent as a parent because then it would have
itself as a dependency which is strange. Maybe we should just specify UTF-8 as
the encoding if that is the problem.
3. Good point, the ASL2.0 license should be included at the top of the XML
files.
> flume-checkstyle module should be consistent with flume-ng prefix convention
> ----------------------------------------------------------------------------
>
> Key: FLUME-2959
> URL: https://issues.apache.org/jira/browse/FLUME-2959
> Project: Flume
> Issue Type: Improvement
> Reporter: Lior Zeno
> Assignee: Lior Zeno
> Priority: Minor
> Fix For: v1.7.0
>
> Attachments: FLUME-2959-0.patch
>
>
> In FLUME-2937 we added the flume-checkstyle module to Flume.
> There are three minor issues with it:
> # It does not follow our modules naming convention. It should be
> flume-ng-checkstyle.
> # It does not declare a parent module, resulting in build warnings (the
> source encoding is not explicitly set to UTF-8)
> # Resource files don't include the ASF licensing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
