> On 七月 29, 2016, 2:49 p.m., Attila Simon wrote:
> > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java,
> > lines 268-288
> > <https://reviews.apache.org/r/50378/diff/4/?file=1457767#file1457767line268>
> >
> > Usage of magic constants like '/', '\', "*?[{" most be avoided.
Thanks. I checked Glob.java in package sun.nio.fs, code is as follows:
private static boolean isRegexMeta(char var0) {
return ".^$+{[]|()".indexOf(var0) != -1;
}
private static boolean isGlobMeta(char var0) {
return "*?[{".indexOf(var0) != -1;
}
> On 七月 29, 2016, 2:49 p.m., Attila Simon wrote:
> > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java,
> > line 239
> > <https://reviews.apache.org/r/50378/diff/4/?file=1457767#file1457767line239>
> >
> > Is this solution follow symlinks? If not then it would be a breaking
> > change.
Sorry?I don't understand the meaning. Could you please explain it more clearly.
> On 七月 29, 2016, 2:49 p.m., Attila Simon wrote:
> > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java,
> > lines 240-242
> > <https://reviews.apache.org/r/50378/diff/4/?file=1457767#file1457767line240>
> >
> > performance downgrade due to the idempotent instantiations of matchers
I agree with you. But is there any good idea?
> On 七月 29, 2016, 2:49 p.m., Attila Simon wrote:
> > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java,
> > line 274
> > <https://reviews.apache.org/r/50378/diff/4/?file=1457767#file1457767line274>
> >
> > could you please explain why the second half was needed? (i >= 1 &&
> > path.charAt(i - 1) != '\')
'\' means the escape character. For example, path =
"/dir/subdira/\*/subdirb/*/subdirc" , then trimPathBeforeFirstWildcard(path)
returns "/dir/subdira/\*/subdirb" , not "/dir/subdira"
- qiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50378/#review144092
-----------------------------------------------------------
On 七月 29, 2016, 12:04 p.m., qiao wen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50378/
> -----------------------------------------------------------
>
> (Updated 七月 29, 2016, 12:04 p.m.)
>
>
> Review request for Flume.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> In our log management project, we wan't to track many log files like this:
> /app/dir1/log.*
> /app/dir2/log.*
> ...
> /app/dirn/log.*
> But TaildirSource can't support wildcards in filegroup directory name. The
> following config is expected:
> a1.sources.r1.filegroups.fg = /app/*/log.*
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 3f08d8b
>
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java
> ad9f720
>
> flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java
> c341054
>
> flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java
> 097ee0b
>
> Diff: https://reviews.apache.org/r/50378/diff/
>
>
> Testing
> -------
>
> All tests in TestTaildirSource passed.
>
>
> Thanks,
>
> qiao wen
>
>
