-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34200/
-----------------------------------------------------------
(Updated 八月 4, 2016, 4:56 a.m.)
Review request for Flume.
Changes
-------
Use approach suggested by Balázs Donát Bessenyei to avoid long pause.
Bugs: FLUME-2689
https://issues.apache.org/jira/browse/FLUME-2689
Repository: flume-git
Description
-------
Reloading conf file will stop old syslog source and start new syslog source.
Stopping syslog tcp source only closes the NioServerSocketChannel, resulting in
the client sends data through the old channel. In that case, the new source
never receives data. The tcpdump shows the events have received but the new
source doesn't and ss shows the client connection stays same with old one.
The right way to stop syslog source is close both the NioSocketChannel and
NioServerSocketChannel, and shutdown the executor.
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
185c00c
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java
10ef8d8
Diff: https://reviews.apache.org/r/34200/diff/
Testing
-------
Thanks,
wei yang
