----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50232/#review145021 -----------------------------------------------------------
Overall looks good. flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java (line 213) <https://reviews.apache.org/r/50232/#comment211176> nit: Would you mind renaming this to didHitChannelException() ? I think it's more descriptive flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java (line 218) <https://reviews.apache.org/r/50232/#comment211177> nit: How about didHitChannelFullException() ? flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java (line 388) <https://reviews.apache.org/r/50232/#comment211178> nit: please either use hitChannelFullException here or don't save it above and just call source.getHitChannelFullException() in the while loop. Otherwise there's really no benefit to storing the variable. - Mike Percy On Aug. 3, 2016, 8:54 a.m., Balázs Donát Bessenyei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50232/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 8:54 a.m.) > > > Review request for Flume, Denes Arvay and Attila Simon. > > > Repository: flume-git > > > Description > ------- > > Spooldir assumes that any ChannelException means that the channel is full and > it does not log the exception message. > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java > d88cc1d > > flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java > 82c5351 > > Diff: https://reviews.apache.org/r/50232/diff/ > > > Testing > ------- > > [INFO] Flume NG Core ...................................... SUCCESS [08:04 > min] > > > Thanks, > > Balázs Donát Bessenyei > >
