----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51112/#review145858 -----------------------------------------------------------
flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java (line 288) <https://reviews.apache.org/r/51112/#comment212213> Could you please change this to `logger.debug("Offsets found: {}", kafkaOffsets)`? It has more or less the same result with some performance gain and it's also easier to read. flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java (line 292) <https://reviews.apache.org/r/51112/#comment212212> I think you want to check `zookeeperOffsets.isEmpty()` here, don't you? flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java (line 296) <https://reviews.apache.org/r/51112/#comment212214> same as in line 288 flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java (line 300) <https://reviews.apache.org/r/51112/#comment212215> same as in line 288 - Denes Arvay On Aug. 15, 2016, 9:56 p.m., Grant Henke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51112/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 9:56 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2972 > https://issues.apache.org/jira/browse/FLUME-2972 > > > Repository: flume-git > > > Description > ------- > > Offsets tracking the position in Kafka consumers change from using zookeeper > for offset storage to Kafka when moving from 0.8.x to 0.9.x. > FLUME-2823 makes the client change in the Kafka Channel but does not ensure > existing offsets get migrated in order to continue consuming where it left > off. > > This patch adds automated logic on startup to check if Kafka offsets exist, > if not and migration is enabled (by default) then the offsets from Zookeeper > are copied and committed to Kafka. > > > Diffs > ----- > > flume-ng-channels/flume-kafka-channel/pom.xml 587b4b4 > > flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java > 90e3288 > > flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannelConfiguration.java > ccf46d9 > > flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java > b63ac9b > flume-ng-doc/sphinx/FlumeUserGuide.rst fde9ff7 > > Diff: https://reviews.apache.org/r/51112/diff/ > > > Testing > ------- > > Unit tests so far. > > > Thanks, > > Grant Henke > >
