----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50562/#review147233 -----------------------------------------------------------
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java (line 88) <https://reviews.apache.org/r/50562/#comment214349> Please implement the suggestion for the UDP source test here as well. Let's get the bound address and port from the source's bound socket rather than try to use DNS to figure it out. - Mike Percy On Aug. 18, 2016, 6:44 a.m., Denes Arvay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50562/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 6:44 a.m.) > > > Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila > Simon. > > > Bugs: FLUME-2797 > https://issues.apache.org/jira/browse/FLUME-2797 > > > Repository: flume-git > > > Description > ------- > > Patch for FLUME-2797 - SyslogTcpSource uses Deprecated Class + Deprecate > SyslogTCPSource > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java > 185c00c > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java > 175bebb > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java > 10ef8d8 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java > e5b7a06 > > Diff: https://reviews.apache.org/r/50562/diff/ > > > Testing > ------- > > - checkstyle passes > - `flume-ng-core` tests pass > - 2 new tests added > > > Thanks, > > Denes Arvay > >
