----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51504/#review147303 -----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java (line 223) <https://reviews.apache.org/r/51504/#comment214423> This can be done in one line flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java (line 295) <https://reviews.apache.org/r/51504/#comment214422> Should this fail the test? flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java (line 316) <https://reviews.apache.org/r/51504/#comment214421> Nit: new line between tests - Grant Henke On Aug. 30, 2016, 3:26 p.m., Jeff Holoman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51504/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 3:26 p.m.) > > > Review request for Flume and Grant Henke. > > > Repository: flume-git > > > Description > ------- > > Added static escape strings localhost, IP and FQDN > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > f640ec9791fb6e067c20ef797691a617a8e472d6 > > flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java > ccc746066e420e772021a4bc758a81736225f76d > > Diff: https://reviews.apache.org/r/51504/diff/ > > > Testing > ------- > > > Thanks, > > Jeff Holoman > >
