-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52216/#review150251
-----------------------------------------------------------




flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
 (line 379)
<https://reviews.apache.org/r/52216/#comment218140>

    Do we need to add "because it was closed normally"? It seems like if it's 
normal we just say "Channel Closed" and if not, you get the error message


- Jeff Holoman


On Sept. 23, 2016, 12:22 p.m., Umesh Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52216/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 12:22 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Added two new booleans to identify the reason for closed channel: 1) 
> isClosedOnStart 2) isClosedNormally
> And checked them to print the appropriate reason for closed channel
> 
> 
> Diffs
> -----
> 
>   
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
>  9d82e43 
> 
> Diff: https://reviews.apache.org/r/52216/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Umesh Chaudhary
> 
>

Reply via email to