-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52279/#review151304
-----------------------------------------------------------
Checkstyle still reports errors:
[INFO] --- maven-checkstyle-plugin:2.17:check (verify) @ flume-ng-core ---
[INFO] There are 11 errors reported by Checkstyle 6.19 with
flume/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/flume/source/NetcatUdpSource.java:[40]
(imports) AvoidStarImport: Using the '.*' form of import should be avoided -
org.jboss.netty.channel.*.
[ERROR] src/main/java/org/apache/flume/source/NetcatUdpSource.java:[71,78]
(whitespace) WhitespaceAround: WhitespaceAround: '{' is not preceded with
whitespace.
[ERROR] src/main/java/org/apache/flume/source/NetcatUdpSource.java:[116]
(indentation) Indentation: 'catch rcurly' have incorrect indentation level 8,
expected level should be 6.
[ERROR] src/main/java/org/apache/flume/source/NetcatUdpSource.java:[124]
(indentation) Indentation: 'operator new lparen' have incorrect indentation
level 8, expected level should be 4.
[ERROR] src/main/java/org/apache/flume/source/NetcatUdpSource.java:[124,9]
(whitespace) MethodParamPad: '(' should be on the previous line.
[ERROR] src/main/java/org/apache/flume/source/NetcatUdpSource.java:[127]
(indentation) Indentation: 'new' have incorrect indentation level 6, expected
level should be 8.
[ERROR] src/main/java/org/apache/flume/source/NetcatUdpSource.java:[132]
(indentation) Indentation: 'method def' child have incorrect indentation level
7, expected level should be one of the following: 8, 10, 12.
[ERROR] src/main/java/org/apache/flume/source/NetcatUdpSource.java:[134]
(indentation) Indentation: 'object def rcurly' have incorrect indentation level
5, expected level should be one of the following: 4, 6, 8.
[ERROR] src/test/java/org/apache/flume/source/TestNetcatUdpSource.java:[42]
(whitespace) EmptyLineSeparator: 'CLASS_DEF' has more than 1 empty lines before.
[ERROR] src/test/java/org/apache/flume/source/TestNetcatUdpSource.java:[44]
(indentation) Indentation: 'LoggerFactory' have incorrect indentation level 4,
expected level should be 6.
[ERROR] src/test/java/org/apache/flume/source/TestNetcatUdpSource.java:[49]
(sizes) LineLength: Line is longer than 100 characters (found 141).
flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java
(line 118)
<https://reviews.apache.org/r/52279/#comment219646>
Should be *...NetcatUdpSource
- Balázs Donát Bessenyei
On Oct. 4, 2016, 6:18 a.m., Tristan Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52279/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2016, 6:18 a.m.)
>
>
> Review request for Flume and Balázs Donát Bessenyei.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Implementation is heavily based on the existing SyslogUDPSource - the tests
> and implementation mirror that. We could consider making it a superclass of
> SyslogUDPSource and removing the syslog parsing, if this was felt tidier.
>
>
> Diffs
> -----
>
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java
> 4f4073a
> flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java
> PRE-CREATION
>
> flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java
> baa8500
>
> flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java
> PRE-CREATION
> flume-ng-doc/sphinx/FlumeUserGuide.rst ab71d38
>
> Diff: https://reviews.apache.org/r/52279/diff/
>
>
> Testing
> -------
>
> Unit tests provided.
>
>
> Thanks,
>
> Tristan Stevens
>
>
