----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52550/#review153062 -----------------------------------------------------------
flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java (line 769) <https://reviews.apache.org/r/52550/#comment222338> Do you think this Thread.sleep could be avoided? If not, do you think you can change it in a way that it will be not-so-prone to flakiness? (Maybe something like at https://reviews.apache.org/r/49025/diff/5#3 ) Thank you for the patch! Can you please rebase it on trunk so that it applies cleanly? Also, please reformat the code to pass checkstyle checks. - Balázs Donát Bessenyei On Oct. 10, 2016, 12:44 p.m., Umesh Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52550/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 12:44 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > Added appropriate function calls to capture eventTakeAttemptCount and > eventPutAttemptCount in KafkaChannel > > > Diffs > ----- > > > flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java > 66b553a > > flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java > 57c0b28 > > Diff: https://reviews.apache.org/r/52550/diff/ > > > Testing > ------- > > Testing Done. > > > Thanks, > > Umesh Chaudhary > >
