----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53231/ -----------------------------------------------------------
Review request for Flume. Repository: flume-git Description ------- Change to fix error where Kafka Channel, Sink and Source sub-configurations aren't tolerant of the configure() method being called more than once (as happens when a Live Config Update happens) Diffs ----- flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java 47c0634 flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java 276fee1 flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java dd40224 flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/TestKafkaSink.java 7eccf76 flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java 195eca3 flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSource.java 9554201 Diff: https://reviews.apache.org/r/53231/diff/ Testing ------- Added unit tests which all would have failed and now pass. Also tested manually for Channel and Sink (Producer settings only), Consumer settings are a little harder as you don't get the verbose logs, however unit tests pass. Thanks, Tristan Stevens
