[
https://issues.apache.org/jira/browse/FLUME-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15720497#comment-15720497
]
Tristan Stevens commented on FLUME-3033:
----------------------------------------
Just to add some interim comments, there are some checkstyle failures (see)
below. Also, we'd need to have some unit tests for this, perhaps using ActiveMQ
as the current unit tests do.
Checkstyle failures:
[INFO] There are 20 errors reported by Checkstyle 6.19 with
flume/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[25] (imports)
AvoidStarImport: Using the '.*' form of import should be avoided -
org.apache.flume.*.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[38] (imports)
AvoidStarImport: Using the '.*' form of import should be avoided -
javax.net.ssl.*.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[45] (imports)
AvoidStarImport: Using the '.*' form of import should be avoided -
java.security.*.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[105,73]
(whitespace) SeparatorWrap: '.' should be on a new line.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[112,74]
(whitespace) SeparatorWrap: '.' should be on a new line.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[120,63]
(whitespace) SeparatorWrap: '.' should be on a new line.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[179,59]
(whitespace) SeparatorWrap: '.' should be on a new line.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[180,48]
(whitespace) SeparatorWrap: '.' should be on a new line.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[258,63]
(whitespace) SeparatorWrap: '.' should be on a new line.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[342]
(indentation) Indentation: 'array initialization' child have incorrect
indentation level 14, expected level should be one of the following: 8, 10.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[344]
(indentation) Indentation: 'method def modifier' have incorrect indentation
level 16, expected level should be one of the following: 10, 12, 14.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[347]
(indentation) Indentation: 'method def rcurly' have incorrect indentation level
16, expected level should be one of the following: 10, 12, 14.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[349]
(indentation) Indentation: 'method def modifier' have incorrect indentation
level 16, expected level should be one of the following: 10, 12, 14.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[352]
(indentation) Indentation: 'method def rcurly' have incorrect indentation level
16, expected level should be one of the following: 10, 12, 14.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[354]
(indentation) Indentation: 'method def modifier' have incorrect indentation
level 16, expected level should be one of the following: 10, 12, 14.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[356]
(indentation) Indentation: 'method def' child have incorrect indentation level
18, expected level should be one of the following: 12, 14, 16.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[357]
(indentation) Indentation: 'method def rcurly' have incorrect indentation level
16, expected level should be one of the following: 10, 12, 14.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[358]
(indentation) Indentation: 'object def rcurly' have incorrect indentation level
14, expected level should be one of the following: 8, 10, 12.
[ERROR] src/main/java/org/apache/flume/source/jms/JMSSource.java:[380] (sizes)
LineLength: Line is longer than 100 characters (found 101).
[ERROR]
src/main/java/org/apache/flume/source/jms/JMSSourceConfiguration.java:[67]
(sizes) LineLength: Line is longer than 100 characters (found 115).
> Add SSL support to JMS source
> -----------------------------
>
> Key: FLUME-3033
> URL: https://issues.apache.org/jira/browse/FLUME-3033
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Affects Versions: v1.7.0
> Reporter: Aleck Kulabukhov
> Labels: features
> Fix For: notrack
>
> Attachments: FLUME_3033_Add_SSL_support_to_JMS_source.patch.zip
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> As a user I want to connect to JMS sources via SSL.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
