[ 
https://issues.apache.org/jira/browse/FLUME-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894321#comment-15894321
 ] 

Tristan Stevens commented on FLUME-3050:
----------------------------------------

Hi [~yuvalif]
I think what you are asking here is for new counters to be added, rather than 
for existing counters not being present on the monitoring URL.

At the moment, most counters are defined for Source, Sink and Channel as 
supertypes, and there are only a few specific overrides for counters 
(KafkaSink, KafkaChannel and KafkaSource are the only ones that I can see).

You can deduce the failure rate by comparing the attempts with the successes, 
but otherwise you'd be in the realms of adding specific counters all over the 
sources and sinks that you've specified. It's certainly possible, but it would 
require a fair amount of re-working to get right.

What you you think?

By the way, at the very least we should re-name the JIRA to something like "Add 
Counters for error conditions"  

> add error stats to monitor URL
> ------------------------------
>
>                 Key: FLUME-3050
>                 URL: https://issues.apache.org/jira/browse/FLUME-3050
>             Project: Flume
>          Issue Type: Improvement
>          Components: Channel, Shell, Sinks+Sources
>    Affects Versions: v1.7.0
>            Reporter: Yuval Lifshitz
>              Labels: features
>
> currently error counters are not present when getting stats. for example:
> {code}
>  > curl http://my-flume-host:44444/metrics
> {"SINK.k1":{"ConnectionCreatedCount":"1","ConnectionClosedCount":"0","Type":"SINK","BatchCompleteCount":"0","BatchEmptyCount":"4","EventDrainAttemptCount":"10","StartTime":"1485348138992","EventDrainSuccessCount":"10","BatchUnderflowCount":"1","StopTime":"0","ConnectionFailedCount":"0"},"CHANNEL.c1":{"ChannelCapacity":"1000000","ChannelFillPercentage":"0.0","Type":"CHANNEL","ChannelSize":"0","EventTakeSuccessCount":"10","EventTakeAttemptCount":"15","StartTime":"1485348138990","EventPutAttemptCount":"10","EventPutSuccessCount":"10","StopTime":"0"},"SOURCE.r1":{"EventReceivedCount":"10","AppendBatchAcceptedCount":"0","Type":"SOURCE","AppendReceivedCount":"0","EventAcceptedCount":"10","StartTime":"1485348138993","AppendAcceptedCount":"0","OpenConnectionCount":"0","AppendBatchReceivedCount":"0","StopTime":"0"}}
> {code}
> return only "good" stats for source, channel and sink.
> to get error you need to look into the log file. this makes it hard to 
> integrate flume into automatic monitoring systems, NMS etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to