[ 
https://issues.apache.org/jira/browse/FLUME-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013092#comment-16013092
 ] 

Hudson commented on FLUME-3092:
-------------------------------

UNSTABLE: Integrated in Jenkins build Flume-trunk-hbase-1 #248 (See 
[https://builds.apache.org/job/Flume-trunk-hbase-1/248/])
FLUME-3092. Extend the FileChannel's monitoring metrics (mpercy: 
[http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=fdc53f338931b96addf06f3f2be59da128656ec0])
* (edit) 
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
* (edit) 
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java
* (edit) 
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java
* (edit) 
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounterMBean.java
* (add) 
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelErrorMetrics.java
* (edit) 
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/instrumentation/FileChannelCounter.java
* (edit) 
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java


> Extend the FileChannel's monitoring metrics
> -------------------------------------------
>
>                 Key: FLUME-3092
>                 URL: https://issues.apache.org/jira/browse/FLUME-3092
>             Project: Flume
>          Issue Type: Improvement
>          Components: File Channel
>    Affects Versions: 1.7.0
>            Reporter: Denes Arvay
>            Assignee: Denes Arvay
>             Fix For: 1.8.0
>
>
> There are already several generic metrics (e.g. {{eventPutAttemptCount}} and 
> {{eventPutSuccessCount}}) which can be used to create compound metrics for 
> monitoring the FileChannel's health.
> Some monitoring system's aren't capable to calculate such derived metrics, 
> though, so I recommend to add the following extra counters to represent if a 
> channel operation failed or the channel is in an unhealthy state.
> - {{eventPutErrorCount}}: incremented if an {{IOException}} occurs during 
> {{put}} operation.
> - {{eventTakeErrorCount}}: incremented if an {{IOException}} or 
> {{CorruptEventException}} occurs during {{take}} operation.
> - {{checkpointWriteErrorCount}}: incremented if an exception occurs during 
> checkpoint write.
> - {{unhealthy}}: this flag represents whether the channel has started 
> successfully (i.e. the replay ran without any problem). This is similar to 
> the already existing {{open}} flag except that the latter is initially false 
> and is set to {{true}} if the initialization (including the log replay) is 
> successfully done. The {{unhealthy}}, in contrary, is {{false}} by default 
> and is set to {{true}} if there is an error during startup.
> Beside these flags I'd also introduce a {{closed}} flag which is the numeric 
> representation (1: closed, 0: open) of the negated (already existing) 
> {{open}} flag.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to