----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60357/#review179264 -----------------------------------------------------------
Ship it! LGTM, I'm about to commit this. - Denes Arvay On June 28, 2017, 6:58 a.m., Siddharth Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60357/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 6:58 a.m.) > > > Review request for Flume and Attila Simon. > > > Repository: flume-git > > > Description > ------- > > Review request for: https://issues.apache.org/jira/browse/FLUME-2905 which is > trying to prevent socket leaks when a netcat port is already bound to an > existing process. > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java > 9513902 > flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatSource.java > 99d413a > > > Diff: https://reviews.apache.org/r/60357/diff/2/ > > > Testing > ------- > > I have tested flume-ng executable generated from my changes and I can confirm > from the lsof output that the sockets do not keep increasing if the port to > which netcat source is trying to bind to is already in use. > The junits are also passing for me for the NetcatSource. > > > Thanks, > > Siddharth Ahuja > >
