[
https://issues.apache.org/jira/browse/FLUME-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072943#comment-16072943
]
Alexander Bij commented on FLUME-2698:
--------------------------------------
Hi [~tmgstev], could you update the jira-issue with description a bit?
Its mend for Flume v1.8.0 with will be linked to Java 8+ according to
[https://issues.apache.org/jira/browse/FLUME-2945].
So the new Jetty version will be 9.4. Than it is ok to ignore Java 7 support.
I have applied your patch against latest trunk. Do you mind if I open a branch
on the GitHub project so I can contribute?
The tests for flume-ng-sink (morphline) fails. I suggest copy&past the
DelegatingServletInputStream from other test folder and include in the
FlumeHttpServletRequestWrapper. I could add this to the branch.
The documentation in FlumeUserGuide.rst is based on Jetty v9.2 and should be
updated accordingly. New url's to
http://www.eclipse.org/jetty/javadoc/9.4.6.v20170531/.
There is also a small typo in your example. It misses the sink reference:
a1.sources.*r1*.HttpConfiguration.SendServerVersion = false.
Most impacted part is HTTPSource off course, I have to investigate a little
more to review that part.
I like the idea of a generic setter based on properties, but have to be careful
here not accidentally setting stuff. For example _setIdleTimeout_ appears on
threadPool and httpConfiguration with a different meaning / goal. O, I see the
test now, it does look good :-) matching class names in the doc examples.
I would like an example setting the connection timeout, which is something I
would like to set first.
> Upgrade Jetty Version
> ---------------------
>
> Key: FLUME-2698
> URL: https://issues.apache.org/jira/browse/FLUME-2698
> Project: Flume
> Issue Type: Bug
> Components: Web
> Affects Versions: 1.6.0, 1.5.1, 1.7.0
> Reporter: Joakim Erdfelt
> Assignee: Tristan Stevens
>
> Flume depends on Jetty 6
> {code:xml}
> <dependency>
> <groupId>org.mortbay.jetty</groupId>
> <artifactId>jetty-util</artifactId>
> <version>6.1.26</version>
> </dependency>
> {code}
> Which was EOL (End of Life) back in 2010 and is no longer fit for production
> use (without heavy customizations and modifications like Google does for GAE,
> just to keep it safe and vulnerability free)
> Jetty was moved to Eclipse.org back during the Jetty 7 days.
> http://eclipse.org/jetty/
> Note that [Jetty 7 and Jetty 8 are now also
> EOL|https://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00069.html] (as
> of 2014)
> Jetty 9 is the only stable and supported version of Jetty now.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
