-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50438/
-----------------------------------------------------------

(Updated 十月 26, 2017, 3 p.m.)


Review request for Flume.


Changes
-------

Fix the read position problem when the file is closed and the bufferEvent is 
not empty


Repository: flume-git


Description
-------

TaidirSource defaults to LINE, this has issue when multiline log events like 
stack traces and have request/responses. Following part is Java traceback logs. 
We expect to have log line start regex Key to aggregate all the log lines till 
the next regex key is found.
2016-07-16 14:59:43,956 ERROR lifecycleSupervisor-1-7 LifecycleSupervisor.run - 
Unable to start EventDrivenSourceRunner: { 
source:cn.yottabyte.flume.source.http.HTTPSource{name:sourceHttp,state:IDLE} } 
- Exception follows.
java.lang.IllegalStateException: Running HTTP Server found in source: 
sourceHttp before I started one. Will not attempt to start.
    at com.google.common.base.Preconditions.checkState(Preconditions.java:145)
    at 
cn.yottabyte.flume.source.http.HTTPSource.startHttpSourceServer(HTTPSource.java:170)
    at cn.yottabyte.flume.source.http.HTTPSource.start(HTTPSource.java:166)
    at 
org.apache.flume.source.EventDrivenSourceRunner.start(EventDrivenSourceRunner.java:44)
    at 
org.apache.flume.lifecycle.LifecycleSupervisor$MonitorRunnable.run(LifecycleSupervisor.java:251)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
    at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
    at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
    at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)


Diffs (updated)
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst 909fe4ab 
  
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java
 633d3c19 
  
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TailFile.java
 42474c4f 
  
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java
 a107a017 
  
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java
 f2347f38 
  
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java
 097ee0ba 


Diff: https://reviews.apache.org/r/50438/diff/5/

Changes: https://reviews.apache.org/r/50438/diff/4-5/


Testing
-------

All tests in TestTaildirSource passed.


Thanks,

qiao wen

Reply via email to