Hi Mike, Thanks for the quick response.
I fully agree that we need to take care about interop between the different components and dependencies. But if you look at the patch in FLUME-3021, it only puts in Elasticsearch dependencies. The issue with Guava, which you saw in FLUME-2921 is no longer there, because since mid-2016 a lot has changed in the Flume trunk and all those dependencies are fixed. It won't even be possible gto apply this patch anymore. The patch in FLUME-3021 works with the latest Elasticsearch versions, without introducing additional dependencies, which might cause problems to other projects. So I think it can be safely merged into trunk. best regards, Helmut -----Original Message----- From: Mike Percy [mailto:[email protected]] Sent: Dienstag, 23. Jänner 2018 20:39 To: [email protected] Subject: Re: Merging to trunk? Hi Helmut, Thank you for bringing this up on dev@ and thank you for the patch. I see there are other people people interested in this component upgrade as well. As you are probably aware, a Flume committer will need to approve the change before I gets merged to trunk. My primary concern w/ merging this would be compatibility of the dependencies. Flume suffers from a kind of a "dependency hell" because of a lack of classloading support (either via OSGI or Java modules). See https://issues.apache.org/jira/browse/FLUME-2293 for a tracking ticket about that issue. What that means is that all of the components that Flume ships must have compatible dependencies with each other which makes changes like this more complex. Therefore I would like someone to verify that mvn dependency:tree does not show conflicts when run from the top level with the new patches. If memory serves, I believe Google Guava is likely to conflict. Also, I think that https://issues.apache.org/jira/browse/FLUME-3021 is a duplicate of https://issues.apache.org/jira/browse/FLUME-2921 which has additional information about the various issues that we need to solve to do this upgrade. I'd be happy to discuss this issue some more on this thread. Mike On Tue, Jan 23, 2018 at 12:57 AM, Wahrmann, Helmut <[email protected]> wrote: > Hi, > > Who decides if/when a patch or pull request gets merged to trunk? > Reason I am asking is for the Elasticsearch support. The current code > in trunk does not work with ES > 2.x. > Currently Elasticsearch is at 6.1. > > In FLUME-3021 we have several patches since March last year. > I have a patched Flume running at a customer since April last year > without any problems. > > So why not merging those changes into the trunk? > As I stated in my comment in FLUME-3021, it will not cause any > problems, cause the current trunk won't work with newer ES versions anyhow. > I doubt that someone is out there still running ES 0.95. > > best regards, > > Helmut >
