Hi Ferenc,
Thank you for creating the first release candidate.
I did the following checks:
1) checked the checksums & the signatures - OK
2) compared the contents of the src.tar.gz with the repository @
release-1.9.0-rc1: here I found the following unnecessary files (they are
not in the repository):
- ./${project.basedir}
- ./.mvn/wrapper/maven-wrapper.jar
- ./flume-checkstyle
- ./flume-ng-sinks/flume-hive-sink/derby.log
2b) after removing these files and directories I verified that the content
of the src.tar.gz matches the content of the repository. I used the
following command: find . -type f | grep -v ".git" | sort | xargs cat |
shasum
3) compiled the contents of the src.tar.gz, it was successful as expected.
4) compared the jars in the bin.tar.gz with the jars created by mvn install
in the src with jardiff [1] and there were only metadata diffs due to the
different environment
Due to the issues found in 2) I'd vote a -1 for this RC and ask Ferenc to
go ahead with creating an RC2.
Plus I found some outdated parts in the User Guide, I've opened a pull
request [2] to remove those, I think it would be worth to include that
change in 1.9 too.
Thanks,
Denes
[1] https://github.com/scala/jardiff
[2] https://github.com/apache/flume/pull/255
On Tue, Dec 4, 2018 at 6:09 PM Ferenc Szabo <szabofe...@apache.org> wrote:
> Dear Flume Community,
>
> This is the 12th release for Apache Flume as a top-level project,
> version 1.9.0. We are voting on release candidate RC1.
>
> It fixes the following issues:
>
> https://raw.githubusercontent.com/apache/flume/release-1.9.0-rc1/CHANGELOG
>
> *** Please cast your vote within the next 72 hours ***
>
> The tarball (*.tar.gz), signature (*.asc), and checksums (*.sha512)
> for the source and binary artifacts can be found here:
> http://people.apache.org/~szaboferee/apache-flume-1.9.0-rc1/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapacheflume-1029/
>
> The tag to be voted on:
>
>
> https://git-wip-us.apache.org/repos/asf?p=flume.git;a=commit;h=4fcf23d7eeecebcad39995bdb8dcfeb03453273b
>
> Flume's KEYS file containing PGP keys we use to sign the release:
> https://svn.apache.org/repos/asf/flume/dist/KEYS
>
> Regards,
> Ferenc
>
