Hi Ferenc,

It seems to me that you have force-pushed a commit removal to the branch.
In the future, please refrain from rewriting history (see
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History ,
https://git1-us-west.apache.org/docs/switching-to-git.html and
https://issues.apache.org/jira/browse/INFRA-14564 )

I agree that these two rules might be conflicting (no changing
released branches and not rewriting history). In cases like this, I
suggest that we leave the "faulty" commit with the corresponding
revert commit on the branch.

What do you think?


Donat

PS. thank you for cherry-picking the fix to trunk!

On Fri, Feb 8, 2019 at 10:44 AM Bessenyei Balázs Donát
<bes...@apache.org> wrote:
>
> Awesome!
>
> Thank you, Ferenc.
>
>
> Donat
>
>
> On Fri, Feb 8, 2019, 10:43 Ferenc Szabo <fsz...@cloudera.com.invalid wrote:
>>
>> Hi Donat,
>>
>> thank you for pointing it out. I did not realize that the PR was not opened
>> to trunk.
>> I will fix it.
>>
>> Ferenc
>>
>> On Fri, Feb 8, 2019 at 7:32 AM Bessenyei Balázs Donát <bes...@apache.org>
>> wrote:
>>
>> > Hi Ferenc Szabó,
>> >
>> > Are you sure flume-1.8 is the right branch for this change? I think
>> > this change should be reverted and the commit cherry-picked to master.
>> > What do you think?
>> >
>> >
>> > Donat
>> >
>> >
>> > On Thu, Feb 7, 2019 at 11:21 PM GitBox <g...@apache.org> wrote:
>> > >
>> > > szaboferee merged pull request #273: FLUME-3311 Update User Guide In
>> > HDFS Sink
>> > > URL: https://github.com/apache/flume/pull/273
>> > >
>> > >
>> > >
>> > >
>> > > ----------------------------------------------------------------
>> > > This is an automated message from the Apache Git Service.
>> > > To respond to the message, please log on GitHub and use the
>> > > URL above to go to the specific comment.
>> > >
>> > > For queries about this service, please contact Infrastructure at:
>> > > us...@infra.apache.org
>> > >
>> > >
>> > > With regards,
>> > > Apache Git Services
>> >

Reply via email to