slem1 commented on a change in pull request #280: FLUME-3327 add useKafkaHeader
option to convert flume headers as kafk…
URL: https://github.com/apache/flume/pull/280#discussion_r320264094
##########
File path:
flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java
##########
@@ -437,7 +438,7 @@ private void setProducerProps(Context context, String
bootStrapServers) {
private Headers toKafkaHeaders(Map<String, String> headers) {
Headers kafkaHeaders = new RecordHeaders();
for (Entry<String, String> header : headers.entrySet()) {
- kafkaHeaders.add(header.getKey(), header.getValue().getBytes());
+ kafkaHeaders.add(header.getKey(),
header.getValue().getBytes(Charsets.UTF_8));
Review comment:
I think expected Charsets should should be configurable through flume
context parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
