tmgstevens commented on a change in pull request #280: FLUME-3327 add
useKafkaHeader option to convert flume headers as kafk…
URL: https://github.com/apache/flume/pull/280#discussion_r329048439
##########
File path:
flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestParseAsFlumeEvent.java
##########
@@ -64,9 +65,12 @@ private void doParseAsFlumeEventFalse(Boolean checkHeaders)
throws Exception {
KafkaProducer<String, byte[]> producer = new KafkaProducer<>(props);
for (int i = 0; i < 50; i++) {
+ RecordHeaders headers = new RecordHeaders();
+ headers.add(KEY_HEADER, (String.valueOf(i) + "-header").getBytes());
Review comment:
What's the significance of `-header` here? Can we make this configurable,
leaving `-header` as default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
