mpercy commented on a change in pull request #305: FLUME-3345 Add Kudu Flume Sinks URL: https://github.com/apache/flume/pull/305#discussion_r343424010
########## File path: flume-ng-sinks/flume-ng-kudu-sink/src/test/resources/log4j2.properties ########## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: nit: I think (at least for consistency) this should be a log4j2.xml file like https://github.com/apache/flume/blob/trunk/flume-ng-sinks/flume-hdfs-sink/src/test/resources/log4j2.xml ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
