bessbd commented on a change in pull request #310: FLUME-3347:Direct buffer
memory causes sink thread to die
URL: https://github.com/apache/flume/pull/310#discussion_r355115014
##########
File path: flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java
##########
@@ -166,6 +166,13 @@ public void run() {
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
+ } catch (Throwable th){
Review comment:
In general, catching `Error` is to be avoided:
https://docs.oracle.com/javase/8/docs/api/java/lang/Error.html . Catching the
superclass `Throwable` falls under the same category.
Can you think of any alternative ways of improvement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
