mpercy commented on a change in pull request #310: FLUME-3347:Direct buffer
memory causes sink thread to die
URL: https://github.com/apache/flume/pull/310#discussion_r355142565
##########
File path: flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java
##########
@@ -166,6 +166,13 @@ public void run() {
} catch (InterruptedException ex) {
Thread.currentThread().interrupt();
}
+ } catch (Throwable th){
Review comment:
@lightzhao, OutOfMemoryError means Flume has run out of memory. Can you
increase the amount of memory you give to Flume instead?
You also may want to consider more carefully tuning the byteCapacity of your
memory channel. See https://flume.apache.org/FlumeUserGuide.html#memory-channel
Either way, I don't think this patch is a good way to work around your OOME
problem.
Edit: For some reason I thought you were using the MemoryChannel. Looking
again, I guess not. Can you simply give Flume more memory? It seems you are
running too close to the memory limit of what you give the JVM via -Xmx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
