hackty edited a comment on issue #314: [FLUME-3352]:Unnecessary canary test will block on readonly spooldir … URL: https://github.com/apache/flume/pull/314#issuecomment-575990582 @bessbd Thanks for your prompt reply. Two unit tests were added to ensure the correctness on the fix. The description of two unit test: **testRenameTrackingPolicyOnReadonlySpoolDirectory** One supplemented to examine the mechanisation of canary (RenameTrackingPolicy is enabled so the spooldir should have the write access.) It can pass no matter before or after the fix. **testTrackerDirTrackingPolicyOnReadonlySpoolDirectory** One that added to ensure the correctness on currect fix.(TrackerDirTrackingPolicy is enabled and the trackdir is different from spooldir. This time the write permission of spooldir is not necessary to the trackdir and also works well.) It can fail before the fix and pass after the fix.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
