tmgstevens commented on a change in pull request #326:
URL: https://github.com/apache/flume/pull/326#discussion_r419929637
##########
File path:
flume-ng-node/src/main/java/org/apache/flume/node/AbstractZooKeeperConfigurationProvider.java
##########
@@ -90,14 +97,24 @@ protected CuratorFramework createClient() {
protected FlumeConfiguration configFromBytes(byte[] configData)
throws IOException {
- Map<String, String> configMap;
- if (configData == null || configData.length == 0) {
- configMap = Collections.emptyMap();
- } else {
- String fileContent = new String(configData, Charsets.UTF_8);
- Properties properties = new Properties();
- properties.load(new StringReader(fileContent));
- configMap = toMap(properties);
+ Map<String, String> configMap = Collections.emptyMap();
+ if (configData != null && configData.length > 0) {
Review comment:
The else case previously set configMap = Collections.emptyMap(). We
should retain this behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
