rgoers commented on pull request #296: URL: https://github.com/apache/flume/pull/296#issuecomment-1064730031
This PR is not solving the problem reported in FLUME-2894. From what I can tell that was fixed in a different PR. This PR purports to solve a problem where the memory channel is stopped before all the items in it are removed. The problem is, that is by design. The memory channel is not durable while others like the FileChannel are so it is ok for them to be stopped while still containing events. If this PR were to be merged it would prevent Flume from shutting down until all events can be delivered. In many cases that is not desirable as the Sink consuming events may not be able to consume them due to downstream problems and so Flume would be prevented from shutting down. For this reason I am closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@flume.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
