rgoers commented on PR #358:
URL: https://github.com/apache/flume/pull/358#issuecomment-1097622563
Yes, I meant that Flume will now have required dependencies on
```
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>simpleclient</artifactId>
</dependency>
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>simpleclient_servlet</artifactId>
</dependency>
```
even if the property isn't enabled. This is one reason I would prefer
something like a flume-prometheus module so you only get those dependencies if
you include flume-prometheus. But, as you say, we are packaging everything as a
zip so putting it in a separate jar probably wouldn't buy anything right now.
But hopefully it will in 2.0. Putting it in a separate module now might make
that work easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
