tmgstevens commented on code in PR #382:
URL: https://github.com/apache/flume/pull/382#discussion_r962332873
##########
flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java:
##########
@@ -421,7 +424,12 @@ private void setProducerProps(Context context, String
bootStrapServers) {
kafkaProps.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
DEFAULT_VALUE_SERIAIZER);
kafkaProps.putAll(context.getSubProperties(KAFKA_PRODUCER_PREFIX));
kafkaProps.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, bootStrapServers);
-
+ // The default value of `ssl.endpoint.identification.algorithm` is
changed to `https`, since kafka client 2.0+
+ // And because flume does not accept an empty string as property value,
+ // so we need to use alternative custom property
`ssl.disableTLSHostnameVerification` to check if enable fqdn check.
Review Comment:
This line is failing checkstyle because it is one character too long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@flume.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
