Late last year I asked on the PMC list about switching to CTR since there 
hadn’t been any commits in a couple of years and reviews just weren’t happening 
[1]. I needed to get a release done to upgrade or eliminate all the 
dependencies with CVEs and waiting for non-existent reviews to happen wasn’t 
really a good option. I realize now I should have mentioned this to you since 
you weren’t part of the PMC at the time but it honestly slipped my mind.

Basically, there are only 3 of us committing to the repo. I trust both you and 
Donat to either commit something you are highly confident in or create a PR if 
you would like another set of eyes. If you create a PR, ask for my review and I 
don’t provide timely feedback then it is on me if there is something I don’t 
like about it later.

IMO CTR as the general policy only makes sense once a repo becomes fairly 
active where it is likely people will be stepping on each others toes. Even at 
Log4j we still use RTC and we have considerably more active people - just not 
all at once or on non-conflicting components. Plus there we tend to talk a lot 
in Slack and on the mailing lists as well as have periodic video chats os there 
aren’t too many surprises.

FWIW, I’m fine with your PRs but I already started the release build. From 
looking at https://docs.spring.io/spring-metrics/docs/current/public/prometheus 
<https://docs.spring.io/spring-metrics/docs/current/public/prometheus> it looks 
like Spring Boot already supports Prometheus so there shouldn’t be any issues 
there.

Just so you know, I started upgrading my Flume projects to 1.10.1 a couple of 
weeks ago and they were doing some really funky things to include some Spring 
stuff since that is the standard for virtually all of our Java stuff. In the 
end I found it was much easier to just add the Spring Boot support than try and 
work around it. Since I need to get those components finalized and there hasn’t 
been too much activity I felt it best to get a release done sooner rather than 
later. I am fine with doing another release whenever it is needed.

Ralph

1. https://lists.apache.org/thread/42nsntkw86z2nks50718fbx10tqwr6cy



> On Oct 9, 2022, at 11:09 PM, Tristan Stevens <tris...@apache.org> wrote:
> 
> I've tried to pick up the Kafka ones where I can as that's probably where my 
> expertise best lies. Ideally, I'd like to update the Kafka client in this 
> release but it's borked because they removed the KafkaServerStartable in 2,8 
> which has killed our unit tests. I'm loathe to throw the unit tests away as I 
> actually think they are a shining beacon of best practice that other projects 
> would be good to follow.
> 
> On other PRs should I wait for a review on 
> https://github.com/apache/flume/pull/358 and 
> https://github.com/apache/flume/pull/351 or shall I just commit them?
> 
> On those and other recent commits (SpringBoot) my understanding is that we're 
> meant to be following RTC, but maybe we should discuss going to CTR?
> 
> Tristan
> 
> ________________________________
> From: Ralph Goers <ralph.go...@dslextreme.com>
> Sent: 09 October 2022 19:08
> To: dev@flume.apache.org <dev@flume.apache.org>
> Subject: Re: Upcoming Flume 1.11.0 release
> 
> Oh. #334 is also TaildirSource.
> 
> Ralph
> 
>> On Oct 9, 2022, at 11:07 AM, Ralph Goers <ralph.go...@dslextreme.com> wrote:
>> 
>> There are several that have to do with the Taildir source. I have a 
>> suspicion that a few might overlap but I haven’t really looked at them. 
>> #369, 368, 367, 337, 336, 313, 295, 291, 279, 213, 207, 159 & 62.
>> 
>> These are certainly not the only ones but just resolving those would 
>> eliminate 15% of our PR backlog. I’m also not very comfortable looking at 
>> any of the Hadoop/HBase/Hive issues & PRs just because I’ve never used 
>> Hadoop & really have no interest in it.
>> 
>> Ralph
>> 
>>> On Oct 9, 2022, at 2:23 AM, Bessenyei Balázs Donát <bes...@apache.org> 
>>> wrote:
>>> 
>>> Which ones are you looking for help with?
>>> 
>>> 
>>> Donat
>>> 
>>> On Sun, Oct 9, 2022 at 1:21 AM Ralph Goers <ralph.go...@dslextreme.com> 
>>> wrote:
>>>> 
>>>> FYI - I have been going through the PRs and Jira issues and am planning on 
>>>> kicking off another Flume release, probably tomorrow.  If you need 
>>>> something added to the release please speak up.
>>>> 
>>>> Note that there are quite a few open PRs that need to be dealt with. There 
>>>> are quite a few that I am not comfortable dealing with on my own and would 
>>>> appreciate help with.
>>>> 
>>>> Ralph
>> 
> 

Reply via email to