busbey commented on code in PR #351: URL: https://github.com/apache/flume/pull/351#discussion_r1009542545
########## flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestFileChannelDocker.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.flume.test.agent; + +import com.google.common.base.Charsets; +import com.google.common.io.Files; +import org.apache.flume.test.util.DockerInstall; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.File; +import java.util.ArrayList; + +import java.util.List; +import java.util.Properties; +import java.util.concurrent.TimeUnit; + +public class TestFileChannelDocker { + + private static final Logger LOGGER = LoggerFactory.getLogger(TestFileChannelDocker.class); + + private static final List<File> tempResources = new ArrayList<File>(); + + private Properties agentProps; + private File sinkOutputDir; + + @Before + public void setUp() throws Exception { + /* Create 3 temp dirs, each used as value within agentProps */ + + final File sinkOutputDir = Files.createTempDir(); + sinkOutputDir.setWritable(true, false); + sinkOutputDir.setReadable(true, false); + tempResources.add(sinkOutputDir.getCanonicalFile()); + final String sinkOutputDirPath = sinkOutputDir.getCanonicalPath(); + LOGGER.info("Created rolling file sink's output dir: " + sinkOutputDirPath); + + final File channelCheckpointDir = Files.createTempDir(); + channelCheckpointDir.setWritable(true, false); + channelCheckpointDir.setReadable(true, false); + tempResources.add(channelCheckpointDir.getCanonicalFile()); + final String channelCheckpointDirPath = channelCheckpointDir.getCanonicalPath(); + LOGGER.info("Created file channel's checkpoint dir: " + channelCheckpointDirPath); + + final File channelDataDir = Files.createTempDir(); + channelDataDir.setWritable(true, false); + channelDataDir.setReadable(true, false); + tempResources.add(channelDataDir.getCanonicalFile()); + final String channelDataDirPath = channelDataDir.getCanonicalPath(); + LOGGER.info("Created file channel's data dir: " + channelDataDirPath); + + /* Build props to pass to flume agent */ + + Properties agentProps = new Properties(); + + // Active sets + agentProps.put("a1.channels", "c1"); + agentProps.put("a1.sources", "r1"); + agentProps.put("a1.sinks", "k1"); + + // c1 + agentProps.put("a1.channels.c1.type", "FILE"); + agentProps.put("a1.channels.c1.checkpointDir", channelCheckpointDirPath); + agentProps.put("a1.channels.c1.dataDirs", channelDataDirPath); + + // r1 + agentProps.put("a1.sources.r1.channels", "c1"); + agentProps.put("a1.sources.r1.type", "EXEC"); + agentProps.put("a1.sources.r1.command", "seq 1 100"); + + // k1 + agentProps.put("a1.sinks.k1.channel", "c1"); + agentProps.put("a1.sinks.k1.type", "FILE_ROLL"); + agentProps.put("a1.sinks.k1.sink.directory", sinkOutputDirPath); + agentProps.put("a1.sinks.k1.sink.rollInterval", "0"); + + this.agentProps = agentProps; + this.sinkOutputDir = sinkOutputDir; + } + + @After + public void tearDown() throws Exception { + DockerInstall.getInstance().stopAgent(); + for (File tempResource : tempResources) { + tempResource.delete(); + } + agentProps = null; + } + + /** + * File channel in/out test. Verifies that all events inserted into the + * file channel are received by the sink in order. + * <p> + * The EXEC source creates 100 events where the event bodies have + * sequential numbers. The source puts those events into the file channel, + * and the FILE_ROLL The sink is expected to take all 100 events in FIFO + * order. + * + * @throws Exception + */ + @Test + public void testInOut() throws Exception { + LOGGER.debug("testInOut() started."); + + + DockerInstall.getInstance().startAgent("a1", agentProps, tempResources); Review Comment: there's a code smell here due to the agent start being in the test while the agent stop is in an after block. either start and stop should both be in the test, or the start should be in a before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@flume.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
