Just wanted to update that I am still working on this. Progress has been a bit slow due to all the distractions with WFH.
I might also precede the "Travis PR" with a one-time "fixup PR" addressing existing known formatting issues and with minor fixes to the Python code (to address the more important PyLint ones) and such. Arvind Shyamsundar -----Original Message----- From: Christopher <ctubb...@apache.org> Sent: Thursday, March 26, 2020 9:32 AM To: fluo-dev <dev@fluo.apache.org> Subject: [EXTERNAL] Re: Static checks for Muchos code These seem like good checks. Could execute these checks in Travis CI. Also, to ignore the `.git` directory, you could change your find command like: find . -type f -a -not -regex '.*/[.]git/.*' -print0 On Thu, Mar 26, 2020 at 12:16 PM Arvind Shyamsundar <arvin...@microsoft.com.invalid> wrote: > > hi folks, > As Muchos has a bunch of non-Java code, I'm planning to enhance the tests we > have for Muchos to include some static checkers as well. Examples of those > include: > > > * Ansible-lint > (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fansible%2Fansible-lint&data=02%7C01%7Carvindsh%40microsoft.com%7C5d83f0a9e23c448e2be508d7d1a34d45%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637208371619125824&sdata=yoTp5kgRPUEdFjQg9NwStMIfldeR4AVi2xET93Vn69M%3D&reserved=0) > for checking issues with Playbooks > * Check for "no newline at end of file" - I could use some ideas here. I > found useful commands online such as [1] which detect this, but I would > totally reuse a more robust way if there is one. > * Check for trailing whitespace outside of Ansible playbooks > (Ansible-lint checks that for playbooks) - again I found trivial way [2] to > do this but would appreciate any tips on more robust ways. > * Maybe also add PyLint > (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pylint.org%2F&data=02%7C01%7Carvindsh%40microsoft.com%7C5d83f0a9e23c448e2be508d7d1a34d45%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637208371619125824&sdata=c92ABhV6gztohZgbjMpboyq%2Bt1LsovffvK4f8h%2B2xNU%3D&reserved=0) > for the Python code. This can be noisy, but a one-time cleanup should > eliminate most of the problems it will find right now. > > Eager to get inputs and discuss before starting work on this. > > [1] > find .-type f -print0 | xargs -0-L1 bash -c 'test "$(tail -c 1 "$0")" && echo > "No new line at end of $0"' > > [2] > grep -r '[[:blank:]]$' . > > Thanks. > > Arvind Shyamsundar
