Oh - I see what you mean. we've had to similar things in Azure DevOps based pipelines in the past, wherein we'd add an always() condition.
Thanks for detecting and fixing this! I have approved the PRs which were still open (I saw Joseph already approved the Fluo one). Take care and stay safe! -----Original Message----- From: Christopher <ctubb...@apache.org> Sent: Tuesday, October 13, 2020 1:40 PM To: fluo-dev <dev@fluo.apache.org> Subject: Re: [EXTERNAL] CI update (I made a mistake) Hi Arvind, No, I wasn't concerned about exceeding storage limits. My understanding is that they automatically age out. The concern is that the logs won't be uploaded *at all* if the condition isn't set. Instead, those steps get skipped entirely by default, if there's a previous failure. However, the logs are only useful for when there's a failure, so it doesn't make sense to upload when there's a success, and not when there's a failure. On Tue, Oct 13, 2020 at 4:10 PM Arvind Shyamsundar <arvin...@microsoft.com.invalid> wrote: > > Hi Christopher, was the concern behind just uploading test results as > artifacts, that we'd run out of GitHub artifact space? GitHub documents > (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.github.com%2Fen%2Ffree-pro-team%40latest%2Fgithub%2Fsetting-up-and-managing-billing-and-payments-on-github%2Fabout-billing-for-github-actions%23about-billing-for-github-actions&data=04%7C01%7Carvindsh%40microsoft.com%7C10420d4cd1e7425a721a08d86fb837fe%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637382184287694570%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3ih8cntNQwlcy9yqqTH3FSb3SSCLWiqvNoMfObyID3o%3D&reserved=0) > the storage limits, and I see that those are quite low and we could easily > overrun them on busy repos (given the default retention period). > > I'll sweep through the PRs - just wanted to understand what motivated you to > introduce the condition. > > Thanks. > > Arvind Shyamsundar > > -----Original Message----- > From: Christopher <ctubb...@apache.org> > Sent: Monday, October 12, 2020 8:25 PM > To: fluo-dev <dev@fluo.apache.org> > Subject: [EXTERNAL] CI update (I made a mistake) > > I made a mistake in my previous PRs to update us to GitHub Actions. I > accidentally configured the workflows to save the test logs when the Maven > step succeeds... rather than when it fails. So, the following PRs fix that, > and save off the logs when the Maven task fails: > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fapache%2Ffluo-yarn%2Fpull%2F24&data=04%7C01%7Carvindsh%40 > microsoft.com%7C10420d4cd1e7425a721a08d86fb837fe%7C72f988bf86f141af91a > b2d7cd011db47%7C1%7C0%7C637382184287694570%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000 > &sdata=%2FpZ6Bbct%2BgNnuqQZ7bzfJq6iKF%2FzTMO5pyHU9KUYupo%3D&re > served=0 > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fapache%2Ffluo-recipes%2Fpull%2F156&data=04%7C01%7Carvinds > h%40microsoft.com%7C10420d4cd1e7425a721a08d86fb837fe%7C72f988bf86f141a > f91ab2d7cd011db47%7C1%7C0%7C637382184287694570%7CUnknown%7CTWFpbGZsb3d > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 1000&sdata=ZNzQ7FLenOqcMfdBCdgWb5psI3D8PxtLjalwf9e5Gmg%3D&rese > rved=0 > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fapache%2Ffluo-examples%2Fpull%2F16&data=04%7C01%7Carvinds > h%40microsoft.com%7C10420d4cd1e7425a721a08d86fb837fe%7C72f988bf86f141a > f91ab2d7cd011db47%7C1%7C0%7C637382184287704565%7CUnknown%7CTWFpbGZsb3d > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > 1000&sdata=ZJ9uOr%2FO3SeXMeLvIdkmpBffAstbKhF%2BMWbjGSlr%2FW8%3D&am > p;reserved=0 > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fapache%2Ffluo-bytes%2Fpull%2F10&data=04%7C01%7Carvindsh%4 > 0microsoft.com%7C10420d4cd1e7425a721a08d86fb837fe%7C72f988bf86f141af91 > ab2d7cd011db47%7C1%7C0%7C637382184287704565%7CUnknown%7CTWFpbGZsb3d8ey > JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C100 > 0&sdata=HPslH1tKc14iyfCafBsZ3SqJQUb0cEri32vqIe%2BQ0e4%3D&reser > ved=0 > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fapache%2Ffluo%2Fpull%2F1106&data=04%7C01%7Carvindsh%40mic > rosoft.com%7C10420d4cd1e7425a721a08d86fb837fe%7C72f988bf86f141af91ab2d > 7cd011db47%7C1%7C0%7C637382184287704565%7CUnknown%7CTWFpbGZsb3d8eyJWIj > oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&am > p;sdata=47ZpJvaLCs2pyvkmiL9cIDfPeb%2FilF5BtTFAx1UbrYc%3D&reserved= > 0 > > My mistake :) > Christopher
