Message:
The following issue has been closed.
Resolver: Ross Gardler
Date: Tue, 17 May 2005 4:46 PM
Actually, on second thoughts I've applied with modifications:
I realised since the location of jettyconf is hard coded as well it is unlikely
that people will be using a different port (we do not currently support custom
jettyconf.xml files). I therefore replaced your hard coded port numbers with a
variable and added a FIXME note to get this port number from the plugin
preferences.
I've made the thread sleep for a while between checks on the port, this will
prevent the thread from consuming too many resources whilst waiting for the
server to finish starting.
I added a timeout to prevent going into an infinite loop if the server fails to
start (or if someone has hacked the jettyconf.xml)
I took the opportunity to improve the error reporting now that you have
provided more places to check the status of the startup.
Let me know if you see any problems with my changes to your patch. Thanks for
the contribution.
---------------------------------------------------------------------
View the issue:
http://issues.cocoondev.org//browse/FOR-499
Here is an overview of the issue:
---------------------------------------------------------------------
Key: FOR-499
Summary: Better server starting in Eclipse plugin
Type: Improvement
Status: Closed
Priority: Minor
Resolution: FIXED
Project: Forrest
Components:
Tool: Eclipse config
Fix Fors:
0.7-dev
Versions:
0.7-dev
Assignee: Ross Gardler
Reporter: Anil Ramnanan
Created: Tue, 17 May 2005 9:44 AM
Updated: Tue, 17 May 2005 4:46 PM
Description:
This patch includes two fixes:
1. It prevents the user from starting more than one instance of the live server
2. It waits until the server is loaded before it opens the web browser.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.cocoondev.org//secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
