Ross Gardler wrote:
David Crossley wrote:
Ross Gardler wrote:
...
I have relicensed the code (I was the previous Copyright holder) and
committed it to
tools/eclipse/plugins/org.apache.forrest.eclipse.servletEngine
This resolves issue FOR-503
...
I see a number of issues:
* duplicate jars, we already have some of them in forrest core.
Yes, I'm not quite sure how to best resolve this. The plugin is useful
as a standalone plugin, so should really be self-contained. I'll raise
an issue.
I've created an issue and made the versions of the jars in the plugin
the same as those in Forrest. Will look into reusing existing jars when
I can.
* jars without accompanying licenses.
* jar filenames not following our naming convention.
Sorry, Lazy, I will sort that out today.
Done.
A couple of jars are still without version numbers as I can't find what
version they are.
Also, I need some advice on the license for xmlParsersAPIs-2.5.jar,
there are three licenses inside the jar:
dom-documentation
dom-software
sax
Right now I have have each of them in the lib directory, and have added
an XMLParserAPIs- prefix. This means there are three licenses for one
jar. Is that OK?
* compiled classes were committed together with a "build" directory
at plugins/org.apache.forrest.eclipse.servletEngine/build/org/burrokeet/
Doh! Will sort.
Done.
* bad URL for License in
features/org.apache.forrest.eclipse.feature/feature.xml
Oh, I missed that, sorry.
Fixed.
* Two references to org.burrokeet (in feature.xml and
NewProjectWizard.java).
That is because I had not moved the code over to ASF when Anil built the
feature. Anil, can you patch this please.
Oh, Anil already did this - patch now applied.
* bloated distribution.
This commit r202158 added a huge quantity of data.
Our svn checkout was 132816 kb before and 144516 kb after
(an increase of 9%). We already have problems with the size
of the distribution due to all the Cocoon stuff.
There is no need for this tool to be included in the distribution. How
about we move the eclipse support stuff into a separate SVN tree?
Although, most of that bloat is from duplicated jars so the above issue
may solve this.
I've removed all the Jetty-plus jars, they are not needed by Forrest,
only by Burrokeet. The Burrokeet project can extend this plugin for the
Jetty-Plus stuff.
Ross
