Thorsten Scherler wrote: > David Crossley escribi??: > > Thorsten Scherler wrote: > > > > > > The main reason is that png can be generate from svg. This is controlled > > > by skins/dispatcher. Maybe the best would be to extract the svg > > > generation to a plugin of its own (it is a couple of dispatcher > > > contracts and structurer definitions). > > > > But the abovementioned link works fine as-is in 'forrest run' mode. > > Need to test that but I am on the run again. > > > > The problem with the resources.xmap is that it is a mix between skin > > > specific matches (like round corner) and general core matches. This xmap > > > I personally consider as one of the highest complex code in our whole > > > code base that is the reason why I did not yet found the time to slim it > > > down to a resources-core.xmap and resources-skin.xmap. > > > > > > Will try to have a look tomorrow. > > > > Is that wise when we are trying to crank out the release? > > I have not said that I want to split them for the release, I wanted to > say I will have a look at the issue. BTW Cyriaque wrote a thread about > cleaning up dispatcher locations for resources. > > > It works fine in html production now. > > ok,
I meant that even before this whole discussion started, it worked properly in html production. Gav started to investigate a scheduled issue about pdf images which has been a long-standing problem. I built the sample to test image handling, which i presume should be the same for skins or dispatcher. Then we went off track. > did you fixed it with > http://svn.apache.org/viewvc?rev=411535&view=rev ? > > Thanks, very much! No, that was just a text tweak. I simply stopped the forrestbot from reporting the break by commenting out that particular demo in main/fresh-site/ in an earlier commit. > > BTW, i see that the dispatcher copy of resources.xmap does not > > use the locationmap at all, whereas the main one does. > > We (I think Ross mainly did it) updated the xmap and extracted the > matches to lm recently. The dispatcher resources.xmap did not got > adopted after this changes. I meant that if someone is investigating the issue, then please work from the main copy. I have noticed a trend lately that when people are helping to investigate core issues, they are considering dispatcher only. We still have skins as default. -David
