Gav.... wrote:

-----Original Message-----
From: Thorsten Scherler (JIRA) [mailto:[EMAIL PROTECTED]
Sent: Thursday, 29 March 2007 5:54 AM
To: [email protected]
Subject: [jira] Closed: (FOR-765) forrest war and classpath issues with
Jetty


     [ https://issues.apache.org/jira/browse/FOR-
765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thorsten Scherler closed FOR-765.
---------------------------------

    Resolution: Fixed

Ok after recompiling forrest with 1.4 I got it starting and see the error
David describes.

Then I looked at the 'forrest war' output:
...
If using JDK 1.4 or above, make sure to set the Java environment variable
-Djava.endorsed.dirs=/home/thorsten/src/apache/forrest/trunk/lib/endorsed
e.g. in the TOMCAT_OPTS (3.3.x) or CATALINA_OPTS (4.x) env variable.
...

I followed above instructions by using:
java -
Djava.endorsed.dirs=/home/thorsten/src/apache/forrest/trunk/lib/endorsed/
-jar start.jar

...and 1.4 is working like a charm.

I saw that message too, assumed it was Tomcat related rather than Jetty. And
then it says 'or above' , well with above 1.4 you don't need it at all, the
message is not accurate as Tomcat and Jetty work fine on 1.5.

So you did the above Tomcat related message and got Jetty working on 1.4?
Sounds good then if it works, can the message be changed to include Jetty
as well as Tomcat as a fix suggestion.

The first part of the message is pretty clear "set the Java environment variable ..."

The second part says "e.g. in the TOMCAT_OPTS..." which is a Tomcat example. I don't read that to mean it is a Tomcat only instruction, only that it is a Tomcat example.

However, if one person feels it is confusing, you can pretty sure it is confusing for another. Nevertheless, we can't possibly put examples for all possible containers.

I'd say remove the e.g. and just leave it at "set the env variable".

You are also correct that this only affects Java 1.4, but I suspect it may affect other java implementations since it is a class loading issue and therefore dependant on what is bundled with the java implementation in use.

I'd say change it to something like "In Sun Java 1.4 and possibly some other Java implementations..."

Ross