Hi,

Le 8 sept. 08 à 10:06, Andreas Schlüns a écrit :

Hi Eric,

The SFX title implementation is an old one and not used any longer in OOo.

Thanks for the information. Just wondering why I see it in the trace ?


There is a complete new implemented XTitle API which resists in the framework module.

Ok.


BTW: The title was specified by our User Experience Team and must be shown exactly that way: <file name> - <product> <module> <debug info> etcpp ...



If you whish to change that you should discuss that first with our User Experience Team.


Well, my purpose is to implement what mac users ask, and what does recommand the Apple Aqua Human Interface Guidelines: this ismostly a Mac OS X only need.

For that, I started a wiki page, describing the feature : http:// wiki.services.openoffice.org/wiki/Special:Search?search=proxy +Icon&go=Consulter

Of course, if the User Experience Team wants to join and help the Mac porting effort, it is welcome :-)


And then it must be implemented in framework also (might be conditional with #ifdef MAC ... #endif) but not in VCL !

Sorry, you mean vcl of VCL (API ) ? About the #ifdef QUARTZ, if we could avoid such #ifdef , I'b be happy :)


A VCL Window has to provide the possibility to set a title on a window only .... not to create such title by itself .-)


The point is not to create the title itself, but to retrieve the information internally. I'll try to explain more:

To implement a proxy icon, we basically need 4 things :

- a pointer on the window (trivial)
- be sure the window is a document (not a dialog box, nor help box .. )
- the full name of the corrent file, (even if not displayed)
- has the document been saved already

With all of that, I know what do, and since this is a Mac OS X feature only ( maybe in Windows in 5 years ;) ) I tried to implement that directly in vcl, but I was hesitating: implement a new method only used on Mac OS X is maybe overengineering. Nevertheless, we'll respect the advices from framework project.


In the code, we have (vcl/aqua/source/window/salframe.cxx ) void AquaSalFrame::SetTitle(const XubString& rTitle)

=> means we do not create the title, but we use what comes from sfx2 (afaic see in the back trace). Maybe the real thing is done elsewhere, but this is secondary here.


Then in the above method, we do (this is Objective C, Mac OS X only) : [mpWindow setTitle:pTitle];

What we can interpret as : the message setTitle, containing the parameter pTitle ( an NSString created from the rTitle), is sent to the Window And we can read on top of the window : <file name> - <product> <module> <debug info>

Instead of that, and to make the proxy icon appear, we could use [mpWindow setTitleWithRepresentedFilename: pTitle]; => The effect is to create the proxy icon *internally* to Mac OS X system, said differently, nothing to do.

The problem is the current file name is not correct because it does contain other informations ( - <product> <module> <debug info> ).

I can be wrong (please explain me), but a File name should IMHO contain either the path + file name or the file name without the path, but not what we currently have, and have another name if other information completes it.

IMHO, this issue is framework relevant, and not user experience. That's why I ask there :)

Last but not least, I fear there is another bug somewhere, because the content of the file name is not predictable , and wrong in some cases.



Please describe more in detail what is your intention and what will be the use case.



I tried, but if you meed more info, just ask.

Thanks,
Eric Bachard

--
qɔᴉɹə




Reply via email to