Hi Felix,
Had you chance to try to remove the mask merging/introduction in the
"GraphicHelper::createThumb_Impl()"? Did it help?
If you have any questions please do not hesitate to ask.
Best regards,
Mikhail.
On 08/ 6/09 12:07 PM, Mikhail Voytenko wrote:
Hi Felix,
On 08/ 6/09 11:31 AM, Zhang Xiaofei wrote:
Hi Mikhail,
Sorry but after our discussion yesterday I still have this confusion:
it seems to me the overlay bitmap is merged into the result bitmap as
a part of the mask.
In case the result bitmap is a transparent one, the mask should of
course be merged to get the correct mask for the generated bitmap. But
this is exactly what we should change, a nontransparent bitmap should
be generated in future, and a nontransparent bitmap does not need the
mask.
So will the method lose the function of adding signatures to
thumbnails if we stop providing the mask to the BitmapEx constructor?
No it should not loose the functionality, since only the mask merging
will be removed. The painting of the overlay bitmap over the thumbnail
bitmap will be enough in this case.
Maybe I could just call BitmapEx::CombineSimple() to merge the two
instead? Please correct me if I'm wrong. I'm looking for your
suggestions.
Please see above, we do not need to merge them at all, all that we
need is just to remove the mask merging, since the bitmap will not be
transparent any more.
Hope that helps.
Best regards,
Mikhail.
Thanks and Best Regards,
Felix.
Mikhail Voytenko
Hi Felix,
you can take the following task as the next one.
http://qa.openoffice.org/issues/show_bug.cgi?id=101732
The generation of the thumbnail is done in
sfx2/source/doc/objstor.cxx in
SfxObjectShell::GenerateAndStoreThumbnail().
Please investigate the code, we can discuss the necessary changes
tomorrow on IRC meeting.
Best regards,
Mikhail.
--
Sun Microsystems GmbH Mikhail Voytenko
Nagelsweg 55 Software Engineer
20097 Hamburg Phone: (+49 40)23646 500
Germany Fax: (+49 40)23646 550
http://www.sun.de mailto:mikhail.voyte...@sun.com
Sitz der Gesellschaft:
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@framework.openoffice.org
For additional commands, e-mail: dev-h...@framework.openoffice.org
