Hi Mathias On Fri, Jun 25, 2010 at 4:53 PM, Mathias Bauer <nospamfor...@gmx.de> wrote:
> Hi, > > > On 06/22/2010 11:38 AM, Zhang Xiaofei wrote: > >> >> >> On Mon, Jun 21, 2010 at 7:55 PM, Carsten Driesner >> <carsten.dries...@sun.com <mailto:carsten.dries...@sun.com>> wrote: >> >> Am 21.06.2010 09:54, schrieb Zhang Xiaofei: >> >> Hi Mikhail, Carsten and all, >> >> I got a number of errors about windows SDK headers when I >> followed the >> compiler's errors to replace the types in >> tools/source/fsys/comdep.cxx and >> it's headers. I cannot find the cause in OOo code and would >> appreciate if >> you can give me some advice, thanks in advance! >> >> Hi Felix, >> >> Could you please tell us what changes you made when you encountered >> that problem? It could be that Windows headers are included which >> need other Windows headers. At least BOOL ist defined by the Windows >> header (windows.h) and shouldn't be an unknown identifier. But this >> could also be related to changes you did. Your job is to exchange >> all types in OpenOffice.org headers which conflict with Windows >> types, e.g. BOOL in tools/inc/tools/solar.h and Windows.h. >> >> Hi Carsten, >> Thanks for the reply. Till now all the changes are just type replacing >> in tools module. I'm attaching the changes as a patch. Could you have a >> look at it if you get time please? >> > > I don't see an attachment. Perhaps it got stripped. > > What is your plan with regard to "BOOL"? Will you just replace every BOOL > by a sal_Bool or will you try to use "bool" as much as possible? The first > option is a safe operation and so it would be the fastest way, the second > one looks just "right", but surely is more work to do. > Thanks for your attention. As in previous discussions with Carsten and Mikhail, the plan will take the sal_Bool option. And sorry about the stripped patch. The latest changes can be found at http://hg.services.openoffice.org/cws/removetooltypes01/rev/69f6f827fb66 , which only includes the BOOL part of the original patch, but I haven't overpass the same error yet. I will appreciate if anyone concerned can give me some advice on it. Thanks very much in advance. Best Regards, Felix.
