I'm sure I have said this in the past... but anyway, this commit reminded
me. I think these URL tricks are quite confusing for the users: {{page=
http://www.google.com#charset=ISO-8859-1}}. Many (most?) will think the
charset part is something that google.com will interpret. I bet most won't
be sure if the anchor part is sent to the server (it never is).Also I don't see how URL as the way to describe data sources will scale. Like what if a data source can't be naturally described with an URL? So at the end, if something is naturally an URL, then adding hacks to it is confusing, as above, and if something not naturally an URL, then forcing URL syntax on it with a fake schema (fake in the sense that the URL API-s can't actually resolve it) is again confusing, or just not nice. On Tue, Feb 9, 2021 at 12:09 AM <[email protected]> wrote: > This is an automated email from the ASF dual-hosted git repository. > > sgoeschl pushed a commit to branch FREEMARKER-154 > in repository https://gitbox.apache.org/repos/asf/freemarker-generator.git > > > The following commit(s) were added to refs/heads/FREEMARKER-154 by this > push: > new e53f96f FREEMARKER-154 Fixed the HTTP URL invocation by setting > an explicit charset > e53f96f is described below > > commit e53f96f92dad5e2eda55106ceda64b25877981da > Author: Siegfried Goeschl <[email protected]> > AuthorDate: Tue Feb 9 00:07:56 2021 +0100 > > FREEMARKER-154 Fixed the HTTP URL invocation by setting an explicit > charset > --- > freemarker-generator-website/src/main/docgen/book.xml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/freemarker-generator-website/src/main/docgen/book.xml > b/freemarker-generator-website/src/main/docgen/book.xml > index 88f97bd..08119ec 100644 > --- a/freemarker-generator-website/src/main/docgen/book.xml > +++ b/freemarker-generator-website/src/main/docgen/book.xml > @@ -962,13 +962,13 @@ freemarker-generator -t > freemarker-generator/info.ftl my_users=[docgen:wd]/examp > used:</para> > > <programlisting>[docgen.insertOutput from="FreeMarker Generator > DataSources" to=r"^\s*$" printCommand=true] > -freemarker-generator -t freemarker-generator/info.ftl > http://google.com?foo=bar > +freemarker-generator <http://google.com?foo=bar+freemarker-generator> -t > freemarker-generator/info.ftl https://www.google.com#charset=ISO-8859-1 > [/docgen.insertOutput]</programlisting> > > <para>and also combined with a name:</para> > > <programlisting>[docgen.insertOutput from="FreeMarker Generator > DataSources" to=r"^\s*$" printCommand=true] > -freemarker-generator -t freemarker-generator/info.ftl page= > http://google.com?foo=bar > +freemarker-generator <http://google.com?foo=bar+freemarker-generator> -t > freemarker-generator/info.ftl page= > http://www.google.com#charset=ISO-8859-1 > [/docgen.insertOutput]</programlisting> > </section> > > > -- Best regards, Daniel Dekany
