+1 (non-binding)

Verified running our testsuite containing some FM related tests
with org.freemarker.freemarker-2.3.31.jar .
no regression found, all testcases successful.

Regards
Christoph

Am Mi., 10. Feb. 2021 um 23:51 Uhr schrieb Woonsan Ko <[email protected]>:

> +1 (binding)
>
> Verified the following:
> - gpg --verify with the .asc files: OK
> - sha512 checksums: OK
> - builds and artifacts in both "normal" and "gae": OK
>   (ant, ant test, ant javadoc, ant manualOffline, ant maven-install)
> - testing in a CMS product with the freemarker-2.3.31.jar: OK
>
> Regards,
>
> Woonsan
>
>
> On Tue, Feb 9, 2021 at 5:20 PM Daniel Dekany <[email protected]> wrote:
> >
> > Hi all,
> >
> > Please vote on releasing FreeMarker 2.3.31!
> >
> > As there were changes in the last few days, don't skip testing with
> > your dependent projects, even if you already did it recently.
> >
> > Release Notes:
> > https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
> >
> > Before proceed, you should know that FreeMarker 2.3.x, for a long
> > time, always releases a normal and a "gae" variant on the same time,
> > which are technically two independent source trees (Git branches). The
> > "gae" variant contains a few small modification in the Java source
> > code to be Google App Engine compliant, and has freemarker-gae as the
> > Maven artifact name. Otherwise the normal and the "gae" branches are
> > identical. Hence they will be voted on together.
> >
> > The commits to be voted upon are:
> > - Normal (non-gae) variant:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
> >   Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
> > - "gae" variant:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> >   Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> >
> > The artifacts to be voted upon are located here:
> > https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
> > where the source release artifacts are:
> > - Normal (non-gae) variant:
> >   apache-freemarker-2.3.31-src.tar.gz
> > - "gae" variant:
> >   apache-freemarker-gae-2.3.31-src.tar.gz
> >
> > See the README.md inside them for build instructions!
> >
> > The release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/ddekany.asc
> >
> > For convenience, we also provide binaries, which also need to be checked:
> >
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
> > and Maven artifacts in the ASF Staging Repository:
> >
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
> >
> > Please try out the package and vote!
> >
> > The vote is open for a minimum of 72 hours or until the necessary number
> of
> > votes (3 binding +1s) is reached.
> >
> > [ ] +1 Release this package as Apache FreeMarker 2.3.31
> > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> > Please add "(binding)" if your vote is binding.
> >
> > --
> > Thanks,
> >  Daniel Dekany

-- 
Synesty GmbH
Moritz-von-Rohr-Str. 1a
07745 Jena
Tel.: +49 3641 
5596493Internet: https://synesty.com <https://synesty.com>
Informationen 
zum Datenschutz: https://synesty.com/datenschutz 
<https://synesty.com/datenschutz>

Geschäftsführer: Christoph Rüger
Unternehmenssitz: Jena
Handelsregister B beim Amtsgericht: Jena
Handelsregister-Nummer: HRB 508766
Ust-IdNr.: DE287564982

Reply via email to