Hi! I attached two fixes and one suggested improvment patch against FSVS 1.1.3 below.
fix_ignore_pattern_bracket_expression_parser.diff.bz2: ****************************************************** FSVS 1.1 merged my ignore pattern changes, but somehow an erroneous "break" got introduced into one loop during the merge, effectively breaking the parsing of bracket expressions. This short one-liner should fix this issue. As I'm pretty sure this is a plain bug I also already comitted it against the SVN trunk. notice_changed_permissions_on_commit.diff.bz2: ********************************************** While working on my suggested fix/improvement below, I noticed a bug regarding detection of changed file access permissions during commit. FSVS currently simply ignores changed file permissions. Files with changed permissions will most probably still be comitted, as the file's mtime will most likely also change at the same time, and FSVS subsequently commits all metadata no matter if changed or not. However if this behaviour is ever changed, it will break. This two-liner should fix this issue. As I'm pretty sure this is a plain bug I also already comitted it against the SVN trunk. do_not_commit_unchanged_files.diff.bz2: *************************************** Even if only its metadata changes, FSVS 1.1.3 will still commit whole file including all its content. This probably went unnoticed as SVN is smart enough to detect that the file's contents didn't change and thus just ignores it, only currectly recording the property / meta-data changes. I noticed it when I changed access permissions on a few hundred photos currently managed using FSVS and FSVS happily began to re-upload all to my remote server... ;) This patch is a suggestion as I'm not entirely sure if this is the correct approach at all, if there is any better way and whether this patch causes any regressions. I'm also not sure what will happen to special files like symlinks after applying this patch. I think it's ok for regular files and it seems to work for me. Your mileage may vary. I did not commit this patch to SVN. Greetings, Gunter -- *** Powered by AudioScrobbler --> http://www.last.fm/user/Interneci/ *** 00:16 | Tristania - Dementia 00:11 | Tristania - Heretique 00:07 | Tristania - Angina 00:06 | Tristania - Simbelmynë *** PGP-Verschlüsselung bei eMails erwünscht :-) *** PGP: 0x1128F25F ***
do_not_commit_unchanged_files.diff.bz2
Description: BZip2 compressed data
notice_changed_permissions_on_commit.diff.bz2
Description: BZip2 compressed data
fix_ignore_pattern_bracket_expression_parser.diff.bz2
Description: BZip2 compressed data
signature.asc
Description: This is a digitally signed message part.
