How about copying the DISCLAIMER,LICENSE,NOTICE directly into the META-INF
directory in every jar? Will this resolve the issue?

On Thu, Mar 28, 2024 at 4:12 AM PJ Fanning <[email protected]> wrote:

> I had a look at the fury-core jar and it has shaded copies of janino
> (including its commons compiler(. I don't think the META-INF LICENSE
> and DEPENDENCIES files account for these correctly. The DEPENDENCIES
> mentions janino as a transitive dependency but it isn't in this case -
> it is embedded. I would prefer if the Janino license was referenced in
> the META-INF/LICENSE file - even if we include the full license in a
> separate file.
>
> On Wed, 27 Mar 2024 at 18:57, PJ Fanning <[email protected]> wrote:
> >
> > Close - stages the jars - but they will be removed if you later Drop
> > Release - irreversible release to Maven Central
> >
> > I find the naming confusing myself.
> >
> > On Wed, 27 Mar 2024 at 18:49, Shawn Yang <[email protected]>
> wrote:
> > >
> > > I closed it on nexus, it can be accessed now. I thought it should be
> closed
> > > when the vote on Incubator is passed.
> > >
> > > On Thu, Mar 28, 2024 at 1:37 AM PJ Fanning <[email protected]>
> wrote:
> > >
> > > > That link is not working. Probably needs some sort of auth.
> > > >
> > > > If you log into https://repository.apache.org/#stagingRepositories,
> > > > you can `close` the repo which will publish the jars to the staging
> > > > area (which is public) [1]
> > > >
> > > > Don't `release` the `orgapachefury-1000` repo because that will
> > > > release it to Maven Central.
> > > >
> > > > If you have trouble, I can do the `close` for you.
> > > >
> > > > [1] https://repository.apache.org/content/groups/staging/
> > > >
> > > > On Wed, 27 Mar 2024 at 18:28, Shawn Yang <[email protected]>
> wrote:
> > > > >
> > > > > Seems I made it work now, it's the configuration issue on my side
> > > > >
> > > > > The jars are
> > > > >
> https://repository.apache.org/content/repositories/orgapachefury-1000 ,
> > > > > please take a look.
> > > > >
> > > > >
> > > > > On Thu, Mar 28, 2024 at 1:20 AM PJ Fanning <[email protected]>
> wrote:
> > > > >
> > > > > > Let's see if INFRA can fix this.
> > > > > >
> > > > > > On Wed, 27 Mar 2024 at 18:14, Shawn Yang <
> [email protected]>
> > > > wrote:
> > > > > > >
> > > > > > > I can't publish jars to apache nexus, the command  `mvn -T10
> deploy
> > > > > > > -Papache-release -DskipTests` raised 400 error:
> > > > > > >
> > > > > > > [ERROR] Failed to execute goal
> > > > > > > org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy
> > > > (default-deploy)
> > > > > > on
> > > > > > > project fury-parent: Failed to deploy artifacts: Could not
> transfer
> > > > > > > artifact org.apache.fury:fury-parent:pom:0.5.0-rc1 from/to
> > > > > > > apache.releases.https (
> > > > > > >
> https://repository.apache.org/service/local/staging/deploy/maven2):
> > > > > > > Transfer failed for
> > > > > > >
> > > > > >
> > > >
> https://repository.apache.org/service/local/staging/deploy/maven2/org/apache/fury/fury-parent/0.5.0-rc1/fury-parent-0.5.0-rc1.pom
> > > > > > > 400 Bad Request -> [Help 1]
> > > > > > >
> > > > > > > On Thu, Mar 28, 2024 at 12:02 AM PJ Fanning <
> [email protected]>
> > > > wrote:
> > > > > > >
> > > > > > > > Could you publish jars built from the git tag/commit to
> Apache
> > > > Nexus
> > > > > > > > Repository Staging area?
> > > > > > > >
> > > > > > > > https://repository.apache.org/content/groups/staging/
> > > > > > > >
> > > > > > > > To set up the pom - see the staging values in:
> > > > > > > > See
> https://github.com/apache/spark/blob/master/pom.xml#L3757-3796
> > > > > > > >
> > > > > > > > You just need to use your Apache ID and password.
> > > > > > > >
> > > > > > > > I can do the INFRA issue - this item about setting up the
> dist area
> > > > > > > > does not need INFRA and it is expected that ASF contributors
> look
> > > > > > > > after it themselves.
> > > > > > > >
> > > > > > > >
> > > > > > > > On Wed, 27 Mar 2024 at 16:01, Shawn Yang <
> [email protected]>
> > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Hi PJ,
> > > > > > > > >
> > > > > > > > > Thanks for helping review the release candidate.
> > > > > > > > >
> > > > > > > > > The commit id is 01220f203dc6066b9cc30e226b13b5846993b35d
> > > > > > > > > I will add it when voting on Incubator and add it to the
> Fury
> > > > > > release doc
> > > > > > > > > later.
> > > > > > > > >
> > > > > > > > > For binaries, jars will be the only binaries in this
> release, the
> > > > > > release
> > > > > > > > > for python and javascript will be postponed in the next
> release.
> > > > > > > > > I filed an issue INFRA-25657 to request apache nexus
> repository
> > > > > > > > permissions,
> > > > > > > > > I will post the links in this thread when the issue is
> resolved.
> > > > > > > > >
> > > > > > > > > Best,
> > > > > > > > > Chaokun Yang
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Wed, Mar 27, 2024 at 6:53 PM PJ Fanning <
> [email protected]>
> > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Thanks for setting up the RC. I have done some checks
> and so
> > > > far,
> > > > > > so
> > > > > > > > good.
> > > > > > > > > >
> > > > > > > > > > With the git tag, the Apache Incubator team prefers to
> be told
> > > > the
> > > > > > > > > > commit id too - because tags can be changed.
> > > > > > > > > >
> > > > > > > > > > Could you also provide details of the binaries like jars
> that
> > > > you
> > > > > > > > > > intend to release with the source release?
> > > > > > > > > >
> > > > > > > > > > On Wed, 27 Mar 2024 at 11:34, Shawn Yang <
> > > > [email protected]>
> > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > Hello, Apache Fury(incubating) Community:
> > > > > > > > > > >
> > > > > > > > > > > This is a call for vote to release Apache
> Fury(Incubating)
> > > > > > > > > > > version release-0.5.0-rc1.
> > > > > > > > > > >
> > > > > > > > > > > Apache Fury(incubating) - A blazing fast multi-language
> > > > > > serialization
> > > > > > > > > > > framework powered by JIT and zero-copy.
> > > > > > > > > > >
> > > > > > > > > > > The change lists about this release:
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > >
> https://github.com/apache/incubator-fury/compare/v0.4.1...v0.5.0-rc1
> > > > > > > > > > >
> > > > > > > > > > > The release candidates:
> > > > > > > > > > >
> > > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc1/
> > > > > > > > > > >
> > > > > > > > > > > Git tag for the release:
> > > > > > > > > > >
> > > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc1
> > > > > > > > > > >
> > > > > > > > > > > The artifacts signed with PGP key [5E580BA4],
> corresponding
> > > > to
> > > > > > > > > > > [[email protected]], that can be found in keys
> file:
> > > > > > > > > > > https://downloads.apache.org/incubator/fury/KEYS
> > > > > > > > > > >
> > > > > > > > > > > The vote will be open until the necessary number of
> votes are
> > > > > > > > reached.
> > > > > > > > > > >
> > > > > > > > > > > Please vote accordingly:
> > > > > > > > > > >
> > > > > > > > > > > [ ] +1 approve
> > > > > > > > > > > [ ] +0 no opinion
> > > > > > > > > > > [ ] -1 disapprove with the reason
> > > > > > > > > > >
> > > > > > > > > > > To learn more about Fury, please see
> > > > https://fury.apache.org/
> > > > > > > > > > >
> > > > > > > > > > > *Valid check is a requirement for a vote. *Checklist
> for
> > > > > > reference:
> > > > > > > > > > >
> > > > > > > > > > > [ ] Download Fury is valid.
> > > > > > > > > > > [ ] Checksums and PGP signatures are valid.
> > > > > > > > > > > [ ] Source code distributions have correct names
> matching the
> > > > > > current
> > > > > > > > > > > release.
> > > > > > > > > > > [ ] LICENSE and NOTICE files are correct.
> > > > > > > > > > > [ ] All files have license headers if necessary.
> > > > > > > > > > > [ ] No compiled archives bundled in source archive.
> > > > > > > > > > > [ ] Can compile from source.
> > > > > > > > > > >
> > > > > > > > > > > More detail checklist please refer:
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > >
> > > > > >
> > > >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > > > > > > > > > >
> > > > > > > > > > > How to Build and Test, please refer to:
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > >
> > > > > >
> > > >
> https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md
> > > > > > > > > > >
> > > > > > > > > > > Thanks!
> > > > > > > > > > > Chaokun Yang
> > > > > > > > > >
> > > > > > > > > >
> > > > > >
> ---------------------------------------------------------------------
> > > > > > > > > > To unsubscribe, e-mail: [email protected]
> > > > > > > > > > For additional commands, e-mail:
> [email protected]
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > To unsubscribe, e-mail: [email protected]
> > > > > > > > For additional commands, e-mail: [email protected]
> > > > > > > >
> > > > > > > >
> > > > > >
> > > > > >
> ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: [email protected]
> > > > > > For additional commands, e-mail: [email protected]
> > > > > >
> > > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: [email protected]
> > > > For additional commands, e-mail: [email protected]
> > > >
> > > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

Reply via email to