[
https://issues.apache.org/jira/browse/GEARPUMP-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309182#comment-15309182
]
ASF GitHub Bot commented on GEARPUMP-83:
----------------------------------------
Github user codecov-io commented on the pull request:
https://github.com/apache/incubator-gearpump/pull/31
## [Current coverage][cc-pull] is **62.77%**
> Merging [#31][cc-pull] into [master][cc-base-branch] will decrease
coverage by **1.32%**
1. 2 files in `.../streaming/appmaster` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6170706D6173746572)
1. 2 files in `...rpump/cluster/master` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F6D6173746572)
- Misses `+71`
- Hits `-71`
1. 2 files (not in diff) in `...mp/streaming/metrics` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6D657472696373)
1. 4 files (not in diff) in `.../streaming/appmaster` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E672F6170706D6173746572)
1. 2 files (not in diff) in `...e/gearpump/streaming` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#73747265616D696E672F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F73747265616D696E67)
- Misses `-1`
- Hits `+1`
1. 2 files (not in diff) in `...he/gearpump/jarstore` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F6A617273746F7265)
- Misses `+8`
- Hits `-8`
1. 2 files (not in diff) in `...mp/cluster/scheduler` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C75737465722F7363686564756C6572)
1. 3 files (not in diff) in `...che/gearpump/cluster` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F636C7573746572)
- Misses `+12`
- Hits `-12`
1. 1 files (not in diff) in `.../org/apache/gearpump` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#6461656D6F6E2F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D70)
1. 5 files (not in diff) in `...apache/gearpump/util` were modified.
[more](https://codecov.io/gh/apache/incubator-gearpump/commit/9529796fc319f1ed69cc6cf726d8f1afef47ef1b/changes?src=pr#636F72652F7372632F6D61696E2F7363616C612F6F72672F6170616368652F6765617270756D702F7574696C)
- Misses `-7`
- Hits `+7`
```diff
@@ master #31 diff @@
==========================================
Files 180 180
Lines 5956 5969 +13
Methods 5678 5689 +11
Messages 0 0
Branches 278 280 +2
==========================================
- Hits 3818 3747 -71
- Misses 2138 2222 +84
Partials 0 0
```
[][cc-pull]
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by
[32f1507...9529796][cc-compare]
[cc-base-branch]:
https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr
[cc-compare]:
https://codecov.io/gh/apache/incubator-gearpump/compare/32f1507171eb4398312deb323f7872eb0bb429f5...9529796fc319f1ed69cc6cf726d8f1afef47ef1b
[cc-pull]: https://codecov.io/gh/apache/incubator-gearpump/pull/31?src=pr
> After killing all worker instances, application status should not be
> described as active
> ----------------------------------------------------------------------------------------
>
> Key: GEARPUMP-83
> URL: https://issues.apache.org/jira/browse/GEARPUMP-83
> Project: Apache Gearpump
> Issue Type: Bug
> Components: Dashboard
> Affects Versions: 0.8.0
> Reporter: Kam Kasravi
> Assignee: Manu Zhang
> Priority: Minor
> Fix For: 0.8.1
>
>
> Step to reproduce:
> Start cluster with one worker
> Start a word count
> Kill the worker
> Expect /api/v1.0/master/applist actually returns app status as active, but
> application's detail page is not available. I think as there is no resource
> to run the application, the application is in some abnormal status. In order
> not to mislead user, I think we should invent a new status, might be
> recovering or something.
> Example output:
> {code}
> {"appMasters":[{"status":"active","appId":1,"appName":"dag","appMasterPath":"akka.tcp://app1-executor-1@127.0.0.1:46761/user/daemon/appdaemon1/$c","workerPath":"akka.tcp://48a47aa6-81c0-493c-9948-9d7d4c946db6@127.0.0.1:59201/user/Worker48a47aa6-81c0-493c-9948-9d7d4c946db6","submissionTime":"1451894551477","startTime":"1451894553568","user":"qxu"},{"status":"active","appId":2,"appName":"wordCount","appMasterPath":"akka.tcp://app2-executor-1@127.0.0.1:49261/user/daemon/appdaemon2/$c","workerPath":"akka.tcp://48a47aa6-81c0-493c-9948-9d7d4c946db6@127.0.0.1:59201/user/Worker48a47aa6-81c0-493c-9948-9d7d4c946db6","submissionTime":"1451898038991","startTime":"1451898040265","user":"qxu"}]}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
