Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/78#discussion_r77100932 --- Diff: examples/streaming/wordcount/src/main/scala/org/apache/gearpump/streaming/examples/wordcount/Split.scala --- @@ -23,29 +23,34 @@ import java.util.concurrent.TimeUnit import org.apache.gearpump.Message import org.apache.gearpump.cluster.UserConfig -import org.apache.gearpump.streaming.source.Watermark +import org.apache.gearpump.streaming.source.{DataSource, DataSourceTask, Watermark} import org.apache.gearpump.streaming.task.{Task, TaskContext} -class Split(taskContext: TaskContext, conf: UserConfig) extends Task(taskContext, conf) { - import taskContext.output - override def onStart(startTime: Instant): Unit = { - self ! Watermark(Instant.now) - } +class Split() extends DataSource { --- End diff -- I prefer `class Split extends DataSource`, no braces.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---